From: APTX <marek321@gmail.com>
Date: Sat, 9 Jun 2012 17:04:59 +0000 (+0200)
Subject: Fix infinite loop in RequestHandler
X-Git-Url: https://gitweb.aptx.org/?a=commitdiff_plain;h=b5149900c8b2a3abd7cab85e946f2c04cf174d43;p=localmylist.git

Fix infinite loop in RequestHandler
---

diff --git a/localmylist/requesthandler.cpp b/localmylist/requesthandler.cpp
index 5b9900b..7546780 100644
--- a/localmylist/requesthandler.cpp
+++ b/localmylist/requesthandler.cpp
@@ -62,11 +62,15 @@ void RequestHandler::handleRequests()
 			| FileAnimeFlag::GroupShortName;
 
 	RaiiTransaction t(db);
+	t.commit();
 
 	QList<PendingRequest> requests = db->getRequestBatch();
 
 	qDebug() << "Got" << requests.count() << " data requests";
 
+	if (!requests.count())
+		return;
+
 	foreach (const PendingRequest &request, requests)
 	{
 		if (request.aid)
@@ -102,8 +106,6 @@ void RequestHandler::handleRequests()
 		}
 	}
 
-	t.commit();
-
 	emit batchFinished();
 }
 
@@ -114,11 +116,15 @@ void RequestHandler::handleMyListUpdates()
 	qDebug() << "handleMyListUpdates";
 
 	RaiiTransaction t(db);
+	t.commit();
 
 	QList<PendingMyListUpdate> requests = db->getPendingMyListUpdateBatch();
 
 	qDebug() << "Got" << requests.count() << " mylist update requests";
 
+	if (!requests.count())
+		return;
+
 	foreach (const PendingMyListUpdate &request, requests)
 	{
 		MyListAddCommand cmd(request.fid, true);
@@ -149,8 +155,6 @@ void RequestHandler::handleMyListUpdates()
 		myListUpdateIdMap.insert(reply, request.updateId);
 	}
 
-	t.commit();
-
 	emit myListUpdateBatchFinished();
 }